Skip to content

Conversation

@MrGeva
Copy link
Collaborator

@MrGeva MrGeva commented Jan 1, 2026

Adding a larger test to get more stable results across ci machines

Summary by CodeRabbit

  • Tests
    • Added a new performance test entry to verify system benchmarking capabilities.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Eran Geva <[email protected]>
@MrGeva
Copy link
Collaborator Author

MrGeva commented Jan 1, 2026

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 1, 2026

📝 Walkthrough

Walkthrough

A new performance test entry for the Llama v3.3 70B Instruct FP8 model is added to the performance test configuration, specifying deployment, quantization, and request parameters for benchmarking.

Changes

Cohort / File(s) Summary
Performance test configuration
tests/integration/test_lists/test-db/l0_perf.yml
Added test entry: llama_v3.3_70b_instruct_fp8-bench-_autodeploy-float8-input_output_len:1024,1024-reqs:8192

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions adding a deepseek_r1_distill_qwen_32b test, but the actual change adds a llama_v3.3_70b_instruct_fp8 test. The title is misleading. Update the title to accurately reflect the added test: '[#8391][chore] added llama_v3.3_70b_instruct_fp8 AutoDeploy perf test to L0'
Description check ❓ Inconclusive The description provides minimal detail beyond 'Adding a larger test to get more stable results across ci machines.' Required sections like Description and Test Coverage are empty or incomplete. Add specific details: explain why this test is needed, what model/parameters are being added, and how test coverage is ensured.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30333 [ run ] triggered by Bot. Commit: 8ac0c29

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30333 [ run ] completed with state SUCCESS. Commit: 8ac0c29
/LLM/main/L0_MergeRequest_PR pipeline #23365 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Signed-off-by: Eran Geva <[email protected]>
@MrGeva
Copy link
Collaborator Author

MrGeva commented Jan 4, 2026

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30492 [ run ] triggered by Bot. Commit: 787c4f7

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30492 [ run ] completed with state SUCCESS. Commit: 787c4f7
/LLM/main/L0_MergeRequest_PR pipeline #23514 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Signed-off-by: Eran Geva <[email protected]>
@MrGeva
Copy link
Collaborator Author

MrGeva commented Jan 4, 2026

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30504 [ run ] triggered by Bot. Commit: 87afa20

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30504 [ run ] completed with state SUCCESS. Commit: 87afa20
/LLM/main/L0_MergeRequest_PR pipeline #23525 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@MrGeva MrGeva changed the title [#8391][chore] added llama_v3.3_70b_instruct_fp8 AutoDeploy perf test to L0 [#8391][chore] added deepseek_r1_distill_qwen_32b AutoDeploy perf test to L0 Jan 4, 2026
@MrGeva MrGeva self-assigned this Jan 4, 2026
@galagam galagam self-requested a review January 4, 2026 18:26
@galagam galagam merged commit e2f5455 into NVIDIA:main Jan 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants